Document `diagnostic_namespace` feature #116611

mejrs · 2023-10-10T19:06:49Z

This adds it to the rust unstable book.

FWIW: I couldn't find a way to serve the book locally (please send help), so I can't check that this renders correctly.

cc @weiznich

rustbot · 2023-10-10T19:06:59Z

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

fmease · 2023-10-10T19:15:07Z

Did you try mdbook serve while you were in the directory of the book?

mejrs · 2023-10-10T19:18:45Z

Did you try mdbook serve while you were in the directory of the book?

That was the first thing i tried, but it gave

2023-10-10 21:18:08 [ERROR] (mdbook::utils): Error: Couldn't open SUMMARY.md in "C:\\Users\\bruno\\Rust\\rust\\src\\doc\\unstable-book\\src" directory
2023-10-10 21:18:08 [ERROR] (mdbook::utils):    Caused By: The system cannot find the file specified. (os error 2)

fmease · 2023-10-10T19:22:12Z

Hmm, I guess boostrap generates the SUMMARY.md. I should probably leave this question to someone else to answer, however you could try to use ./x b <path/to/book> or a variation thereof.

ehuss · 2023-10-10T19:24:15Z

To build the documentation, you need to run ./x.py doc src/doc/unstable-book --open. We don't have support for automatically rebuilding the book.

There's a little bit of documentation on this at https://rustc-dev-guide.rust-lang.org/contributing.html#writing-documentation, but that isn't very discoverable. We should probably add something somewhere to point that out.

Thanks for adding this!

@bors r+ rollup

bors · 2023-10-10T19:24:17Z

📌 Commit 521cd0b has been approved by ehuss

It is now in the queue for this repository.

ehuss · 2023-10-10T19:53:03Z

Oops, forgot the example needs to compile.

@bors r-

I think the code block needs something like rust,compile_fail,E0277

You can test it with ./x.py test src/doc/unstable-book

mejrs · 2023-10-10T22:39:55Z

@rustbot ready

ehuss · 2023-10-10T23:07:55Z

Thanks!

@bors r+ rollup

bors · 2023-10-10T23:07:57Z

📌 Commit ba02a99 has been approved by ehuss

It is now in the queue for this repository.

Rollup of 4 pull requests Successful merges: - rust-lang#95967 (Add explicit-endian String::from_utf16 variants) - rust-lang#116530 (delay a bug when encountering an ambiguity in MIR typeck) - rust-lang#116611 (Document `diagnostic_namespace` feature) - rust-lang#116612 (Remove unused dominator iterator) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116611 - mejrs:diagnostic_namespace, r=ehuss Document `diagnostic_namespace` feature This adds it to the rust unstable book. FWIW: I couldn't find a way to serve the book locally (please send help), so I can't check that this renders correctly. cc `@weiznich`

rustbot assigned ehuss Oct 10, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 10, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2023

Document diagnostic_namespace feature

ba02a99

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 10, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2023

aliemjay mentioned this pull request Oct 11, 2023

Rollup of 4 pull requests #116621

Merged

bors merged commit 494e971 into rust-lang:master Oct 11, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 11, 2023

Dajamante mentioned this pull request Oct 12, 2023

Pull upstream master 2023 10 12 ferrocene/ferrocene#48

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document `diagnostic_namespace` feature #116611

Document `diagnostic_namespace` feature #116611

mejrs commented Oct 10, 2023

rustbot commented Oct 10, 2023

fmease commented Oct 10, 2023 •

edited

Loading

mejrs commented Oct 10, 2023

fmease commented Oct 10, 2023 •

edited

Loading

ehuss commented Oct 10, 2023

bors commented Oct 10, 2023

This comment has been minimized.

ehuss commented Oct 10, 2023

mejrs commented Oct 10, 2023

ehuss commented Oct 10, 2023

bors commented Oct 10, 2023

Document diagnostic_namespace feature #116611

Document diagnostic_namespace feature #116611

Conversation

mejrs commented Oct 10, 2023

rustbot commented Oct 10, 2023

fmease commented Oct 10, 2023 • edited Loading

mejrs commented Oct 10, 2023

fmease commented Oct 10, 2023 • edited Loading

ehuss commented Oct 10, 2023

bors commented Oct 10, 2023

This comment has been minimized.

ehuss commented Oct 10, 2023

mejrs commented Oct 10, 2023

ehuss commented Oct 10, 2023

bors commented Oct 10, 2023

Document `diagnostic_namespace` feature #116611

Document `diagnostic_namespace` feature #116611

fmease commented Oct 10, 2023 •

edited

Loading

fmease commented Oct 10, 2023 •

edited

Loading